Skip to content

Conversation

@0xjei
Copy link
Contributor

@0xjei 0xjei commented Mar 27, 2025

Description

This PR aims to add an index_of() fn to IMT impl to mirror the TS implementation. The function takes a leaf and returns an Option<usize> that evaluate to Some(idx) where idx is the index of the leaf or None when the leaf does not exists in the IMT.

Checklist

  • I have read and understand the contributor guidelines and code of conduct.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Important

We do not accept minor grammatical fixes (e.g., correcting typos, rewording sentences) unless they significantly improve clarity in technical documentation. These contributions, while appreciated, are not a priority for merging. If there is a grammatical mistake, please feel free to message the team.

@0xjei 0xjei requested a review from vplasencia as a code owner March 27, 2025 16:21
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much @0xjei 💯

@vplasencia vplasencia merged commit c51185c into zk-kit:main Jun 9, 2025
5 checks passed
vplasencia pushed a commit that referenced this pull request Jun 10, 2025
## 🤖 New release
* `zk-kit-imt`: 0.0.6 -> 0.0.7

<details><summary><i><b>Changelog</b></i></summary><p>

## `zk-kit-imt`
<blockquote>

##
[0.0.7](zk-kit-imt-v0.0.6...zk-kit-imt-v0.0.7)
- 2025-06-10

### Other
- Add missing `index_of()` fn
([#67](#67))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants