[Invoker] Add interactive problems support #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmusya
reviewed
Apr 20, 2025
grphil
force-pushed
the
dev/invoker/interactive
branch
from
afa9cc5 to
889d5cf
Compare
gmusya
approved these changes
Apr 20, 2025
misha567889
reviewed
Apr 21, 2025
Comment on lines
87
to
+94
| case verdict.TL: | ||
| return fmt.Errorf("checker running took more than %v time", s.test.checkConfig.TimeLimit) | ||
| return fmt.Errorf("%s running took more than %v time", cmd, s.test.checkConfig.TimeLimit) | ||
| case verdict.ML: | ||
| return fmt.Errorf("checker running took more than %v memory", s.test.checkConfig.MemoryLimit) | ||
| return fmt.Errorf("%s running took more than %v memory", cmd, s.test.checkConfig.MemoryLimit) | ||
| case verdict.WL: | ||
| return fmt.Errorf("checker running took more than %v wall time", s.test.checkConfig.WallTimeLimit) | ||
| return fmt.Errorf("%s running took more than %v wall time", cmd, s.test.checkConfig.WallTimeLimit) | ||
| case verdict.SE: | ||
| return fmt.Errorf("checker security violation") | ||
| return fmt.Errorf("%s security violation", cmd) |
Collaborator
There was a problem hiding this comment.
такое чувство, будто тут лучше все же добавить какие-нибудь кавычки, чтобы легко разделить команду и остальную ошибку
Collaborator
There was a problem hiding this comment.
а, cmd это тип штуки из тестлиба
мб тогда енум
Collaborator
Author
There was a problem hiding this comment.
Ну если честно, хз зачем тут enum, тут же строка которая ни для чего кроме логов не используется
Collaborator
There was a problem hiding this comment.
мб назвать переменную как-то иначе
у меня cmd ассоциируется с какой-то командой (мб это я дурак)
misha567889
approved these changes
Apr 22, 2025
Collaborator
misha567889
left a comment
misha567889
left a comment
There was a problem hiding this comment.
по поводу cmd -- это минорно, наверное можно пока так оставить
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.