Skip to content

Conversation

@grphil
Copy link
Collaborator

@grphil grphil commented Apr 18, 2025

No description provided.

@grphil grphil force-pushed the dev/invoker/interactive branch from afa9cc5 to 889d5cf Compare April 20, 2025 13:11
Comment on lines 87 to +94
case verdict.TL:
return fmt.Errorf("checker running took more than %v time", s.test.checkConfig.TimeLimit)
return fmt.Errorf("%s running took more than %v time", cmd, s.test.checkConfig.TimeLimit)
case verdict.ML:
return fmt.Errorf("checker running took more than %v memory", s.test.checkConfig.MemoryLimit)
return fmt.Errorf("%s running took more than %v memory", cmd, s.test.checkConfig.MemoryLimit)
case verdict.WL:
return fmt.Errorf("checker running took more than %v wall time", s.test.checkConfig.WallTimeLimit)
return fmt.Errorf("%s running took more than %v wall time", cmd, s.test.checkConfig.WallTimeLimit)
case verdict.SE:
return fmt.Errorf("checker security violation")
return fmt.Errorf("%s security violation", cmd)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

такое чувство, будто тут лучше все же добавить какие-нибудь кавычки, чтобы легко разделить команду и остальную ошибку

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а, cmd это тип штуки из тестлиба
мб тогда енум

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну если честно, хз зачем тут enum, тут же строка которая ни для чего кроме логов не используется

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мб назвать переменную как-то иначе
у меня cmd ассоциируется с какой-то командой (мб это я дурак)

@grphil grphil requested a review from misha567889 April 22, 2025 17:05
Copy link
Collaborator

@misha567889 misha567889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

по поводу cmd -- это минорно, наверное можно пока так оставить

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants