Updated the readme simplist example. #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made it a bit more complicated, but at least anyone reading won't have to ask amiright lol
TheAssassin
requested changes
Mar 17, 2018
README.md
Outdated
| │ └── your_app.desktop | ||
| └── icons | ||
| └── hicolor | ||
| └── 256x256 |
Collaborator
There was a problem hiding this comment.
Replace this with some kind of template. I suggest:
└── <theme>
(for example, hicolor, ...; see https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html for details)
└── <resolution>
(for example, 256x256, scalable, ...; see https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html for details)
README.md
Outdated
|
|
||
| Where the _desktop_ file specifies the executable to be run (with `EXEC=`), the name of the applications and an icon. | ||
| See [desktop file specification](https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html). | ||
| Now you can say: `linuxdeployqt path/to/AppDir/usr/share/applications/your_app.desktop` |
Collaborator
There was a problem hiding this comment.
s/linuxdeployqt/linuxdeployqt-continuous-x86_64.AppImage/g
Collaborator
|
Thanks. Please see my comments. |
* a template in the AppDir tree instead of hardcoded values * replaced linuxdeployqt with linuxdeployqt-continuous-x86_64.AppImage in the commandline example
Author
|
Alright, I updated the PR. |
TheAssassin
approved these changes
Mar 17, 2018
Owner
|
Thank you very much @lordadamson - this kind of contribution is highly appreciated. 👍 |
Author
|
You're very welcome 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made it a bit more complicated, but at least anyone reading won't have to ask amiright lol