Skip to content

Conversation

@patrickelectric
Copy link
Contributor

@patrickelectric patrickelectric commented Mar 30, 2018

Fix #259
Fix #261
Signed-off-by: Patrick José Pereira patrickelectric@gmail.com

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@patrickelectric patrickelectric changed the title shared: Add libfreetype in excludelist shared: Update exclude list Mar 30, 2018
@TheAssassin
Copy link
Collaborator

TheAssassin commented Mar 31, 2018

I thought the list was auto updated during the Travis build?

@probonopd
Copy link
Owner

I thought the list was auto updated during the Travis build?

I don't understand what you mean @TheAssassin. I keep this list in the C source code updated by hand, so that it is (more or less) in sync with https://github.com/AppImage/AppImages/blob/master/excludelist.

@TheAssassin
Copy link
Collaborator

I see. @probonopd I would then vote for automatically editing this list in some way on Travis CI to ensure it is up to date.

@TheAssassin TheAssassin merged commit 9e95a47 into probonopd:master Mar 31, 2018
@probonopd
Copy link
Owner

Might be worth doing - although I have no clue how...

@TheAssassin
Copy link
Collaborator

@probonopd it isn't that hard. We can have CMake download the list, perform some string manipulations, and provide it as a compiler definition or something like that. We could also run a bash script preparing the list by generating some header file in the build directory.

@TheAssassin
Copy link
Collaborator

Oh, right, this is a qmake project... well I'm sure there's a way to do it with qmake as well.

@patrickelectric
Copy link
Contributor Author

@TheAssassin @probonopd done in #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants