arc() silently fails with Infinity/NaN values ( no console warnings)

[Homaid]

Most appropriate sub-area of p5.js?

• Accessibility
• Color
• Core/Environment/Rendering
• Data
• DOM
• Events
• Image
• IO
• Math
• Typography
• Utilities
• p5.strands
• WebGL
• DevOps, Build process, Unit testing
• Internationalization (i18n)
• Friendly Errors
• Other (specify if possible)

p5.js version

1.11.1

Web browser and version

Chrome 138.0.0.0 (64-bit)

Operating system

windows 11

Steps to reproduce this

Steps:

1. Open https://editor.p5js.org/
2. Paste the following code into the editor.
3. Observe that no console warnings appear, even though invalid parameters are passed to arc().

Snippet:

function setup() {
  createCanvas(400, 400);
  strokeWeight(2);
}

function draw() {
  background(220);
  
  // Extreme / invalid values
  arc(100, 100, 80, 80, 0, 1000);           // Huge end angle
  arc(200, 100, 80, 80, -1000, 1000);       // Huge range
  arc(300, 100, 80, 80, Infinity, Infinity); // Infinity inputs
  arc(100, 200, 80, 80, NaN, PI);            // NaN value
  arc(200, 200, -80, -80, 0, PI);            // Negative radius
  arc(300, 200, Infinity, Infinity, 0, PI);  // Infinite radius
  
  print("Frame:", frameCount);
}

[Homaid]

Hi @davepagurek

I noticed this while testing arc() with some extreme values it silently fails when passed NaN, Infinity, or negative radii without showing any console warnings. I wanted to check if this is considered a valid issue for improvement.

If it seems worth fixing, I’d love to work on it and submit a PR

[davepagurek]

Hey @Homaid! this does sound like something a warning would be helpful for. Also I see youve found this in 1.11.1, it'd also be worth checking if it's in 2.0.5 and making the same change there afterwards too.

[Homaid]

hiii @davepagurek Thanks for asking me to check! I've already submitted the PR for main branch, where I added validation that checks for Infinity, NaN, and negative/zero values in all numeric parameters of arc().

For version 2.0.5 , I found that it already has validation warnings for Infinity and NaN values, which is good. However, there's an issue with the warning message itself. Currently, it says "Expected number at the fifth parameter in arc()." The problem is that in JavaScript, Infinity and NaN are technically numbers so the message "Expected number" is confusing and misleading for users who receive this warning.

I think it would be clearer to change the message in 2.0.5 to either "Expected finite number at the fifth parameter" or use the same approach I implemented in the main branch which explicitly states what value was received and why it's invalid.

[Homaid]

btw whenever you get time can you review my pr thanks again :)