Refactor Locale class and add LocaleProvider test #1283
+162
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the setLocale parameter in the Locale class to be nullable and updated its usage to safely invoke it. This allows for more flexible instantiation when a setLocale function is not required.
Replaces the call to locale.setLocale with locale.set in LocaleKtTest to match the updated API for changing the locale.
catilac
approved these changes
Oct 16, 2025
Comment on lines
-17
to
+31
| val locale = java.util.Locale.getDefault() | ||
| load(ClassLoader.getSystemResourceAsStream("PDE.properties")) | ||
| load(ClassLoader.getSystemResourceAsStream("PDE_${locale.language}.properties") ?: InputStream.nullInputStream()) | ||
| load(ClassLoader.getSystemResourceAsStream("PDE_${locale.toLanguageTag()}.properties") ?: InputStream.nullInputStream()) | ||
| load(ClassLoader.getSystemResourceAsStream("PDE_${language}.properties") ?: InputStream.nullInputStream()) | ||
| loadResourceUTF8("PDE.properties") | ||
| loadResourceUTF8("PDE_${locale.language}.properties") | ||
| loadResourceUTF8("PDE_${locale.toLanguageTag()}.properties") | ||
| loadResourceUTF8("PDE_${language}.properties") |
Comment on lines
+125
to
+128
| CompositionLocalProvider(LocalLayoutDirection provides dir) { | ||
| CompositionLocalProvider(LocalLocale provides locale) { | ||
| content() | ||
| } |
There was a problem hiding this comment.
Ah cool! So this is like how things are composable? People can pass in a block that will be wrapped by this Locale work
There was a problem hiding this comment.
Exactly, if you want access to localised strings you do
LocaleProvider {
val locale = LocalLocale.current
val localizedString = locale["someKey"]
}
And the beatiful things about these contexts is that if you want to display say something in Spanish within the English interface, you can override the LocalLocale with a CompositionLocalProvider. In that case its not super helpful but there's a lot of other cases where its very much is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the Jetpack Compose UI, we would like to have a reactive component that we can use to read and set Processing's Locale live. This PR will improve on the existing functionality and adds testing.
Part of #1280