feat: enhance permissions and error handling in configuration files

Author: productdevbook

.claude/settings.local.json

@@ -3,7 +3,11 @@
     "allow": [
       "Bash(go build:*)",
       "Bash(go vet:*)",
-      "Bash(make build:*)"
+      "Bash(make build:*)",
+      "Bash(brew install:*)",
+      "Bash(go install:*)",
+      "Bash(golangci-lint run:*)",
+      "Bash(golangci-lint help:*)"
     ]
   },
   "enableAllProjectMcpServers": true,

.golangci.yml

@@ -1,19 +1,22 @@
+version: "2"
+
 run:
   timeout: 5m
-  modules-download-mode: readonly
 
 linters:
   enable:
     - errcheck
-    - gosimple
     - govet
     - ineffassign
     - staticcheck
     - unused
+
+formatters:
+  enable:
     - gofmt
     - goimports
 
-linters-settings:
+settings:
   errcheck:
     check-type-assertions: true
     check-blank: false
@@ -23,19 +26,11 @@ linters-settings:
     disable:
       - fieldalignment
 
-  gofmt:
-    simplify: true
-
   goimports:
-    local-prefixes: devir
+    local-prefixes:
+      - devir
 
 issues:
   exclude-use-default: false
   max-issues-per-linter: 0
   max-same-issues: 0
-
-  exclude-rules:
-    # Ignore long lines in generated files
-    - path: _test\.go
-      linters:
-        - errcheck

cmd/devir/main.go

@@ -77,7 +77,7 @@ func runMCPMode(cfg *config.Config, socketPath string) {
 			fmt.Fprintf(os.Stderr, "Failed to connect to daemon: %v\n", err)
 			os.Exit(1)
 		}
-		defer client.Close()
+		defer func() { _ = client.Close() }()
 
 		mcpServer := mcp.NewWithClient(cfg, client, Version)
 		if err := mcpServer.Run(); err != nil {
@@ -101,7 +101,7 @@ func runMCPMode(cfg *config.Config, socketPath string) {
 		fmt.Fprintf(os.Stderr, "Failed to connect to daemon: %v\n", err)
 		os.Exit(1)
 	}
-	defer client.Close()
+	defer func() { _ = client.Close() }()
 
 	mcpServer := mcp.NewWithClient(cfg, client, Version)
 	if err := mcpServer.Run(); err != nil {
@@ -137,7 +137,7 @@ func runTUIMode(cfg *config.Config, socketPath string) {
 			fmt.Fprintf(os.Stderr, "Failed to connect to daemon: %v\n", err)
 			os.Exit(1)
 		}
-		defer client.Close()
+		defer func() { _ = client.Close() }()
 
 		// Start TUI with client
 		p := tea.NewProgram(
@@ -187,7 +187,7 @@ func runTUIMode(cfg *config.Config, socketPath string) {
 		fmt.Fprintf(os.Stderr, "Failed to connect to daemon: %v\n", err)
 		os.Exit(1)
 	}
-	defer client.Close()
+	defer func() { _ = client.Close() }()
 
 	// Start services via daemon
 	_, err = client.StartAndWait(services, killPorts, 10*1e9) // 10 seconds timeout

internal/daemon/client.go

@@ -11,14 +11,14 @@ import (
 
 // Client connects to a daemon
 type Client struct {
-	conn     net.Conn
-	sendCh   chan Message
-	recvCh   chan Message
-	closeCh  chan struct{}
-	wg       sync.WaitGroup
-	mu       sync.Mutex
-	closed   bool
-	handlers map[string]func(Message)
+	conn      net.Conn
+	sendCh    chan Message
+	recvCh    chan Message
+	closeCh   chan struct{}
+	wg        sync.WaitGroup
+	mu        sync.Mutex
+	closed    bool
+	handlers  map[string]func(Message)
 	handlerMu sync.RWMutex
 }
 
@@ -129,7 +129,7 @@ func (c *Client) Close() error {
 	c.mu.Unlock()
 
 	close(c.closeCh)
-	c.conn.Close()
+	_ = c.conn.Close()
 	c.wg.Wait()
 	return nil
 }

internal/daemon/daemon.go

@@ -46,10 +46,10 @@ func Exists(socketPath string) bool {
 	conn, err := net.Dial("unix", socketPath)
 	if err != nil {
 		// Socket file might exist but daemon not running
-		os.Remove(socketPath)
+		_ = os.Remove(socketPath)
 		return false
 	}
-	conn.Close()
+	_ = conn.Close()
 	return true
 }
 
@@ -84,7 +84,7 @@ func New(cfg *config.Config, socketPath string) *Daemon {
 // Start starts the daemon
 func (d *Daemon) Start() error {
 	// Remove stale socket
-	os.Remove(d.socketPath)
+	_ = os.Remove(d.socketPath)
 
 	listener, err := net.Listen("unix", d.socketPath)
 	if err != nil {
@@ -119,17 +119,17 @@ func (d *Daemon) Stop() {
 	}
 
 	if d.listener != nil {
-		d.listener.Close()
+		_ = d.listener.Close()
 	}
 
 	d.clientsMu.Lock()
 	for c := range d.clients {
-		c.conn.Close()
+		_ = c.conn.Close()
 	}
 	d.clientsMu.Unlock()
 
 	d.wg.Wait()
-	os.Remove(d.socketPath)
+	_ = os.Remove(d.socketPath)
 }
 
 func (d *Daemon) acceptLoop() {
@@ -194,7 +194,7 @@ func (c *clientConn) cleanup() {
 	delete(c.daemon.clients, c)
 	c.daemon.clientsMu.Unlock()
 	close(c.sendCh)
-	c.conn.Close()
+	_ = c.conn.Close()
 }
 
 func (c *clientConn) send(msg Message) {
@@ -260,7 +260,7 @@ func (d *Daemon) handleStart(c *clientConn, msg Message) {
 				if runner.IsPortInUse(svc.Port) {
 					pid, _ := runner.GetPortPID(svc.Port)
 					if pid > 0 {
-						runner.KillProcess(pid)
+						_ = runner.KillProcess(pid)
 					}
 				}
 			}
@@ -328,7 +328,7 @@ func (d *Daemon) handleRestart(c *clientConn, msg Message) {
 
 	d.runner.RestartService(req.Service)
 
-	resp, _ := NewMessage(MsgRestarted, RestartedResponse{Service: req.Service})
+	resp, _ := NewMessage(MsgRestarted, RestartedResponse(req))
 	c.send(resp)
 }
 
@@ -479,7 +479,7 @@ func (d *Daemon) StartServices(services []string, killPorts bool) error {
 				if runner.IsPortInUse(svc.Port) {
 					pid, _ := runner.GetPortPID(svc.Port)
 					if pid > 0 {
-						runner.KillProcess(pid)
+						_ = runner.KillProcess(pid)
 					}
 				}
 			}

internal/mcp/mcp.go

@@ -90,7 +90,7 @@ func (m *Server) Run() error {
 
 	go func() {
 		<-sigCh
-		m.client.Stop()
+		_ = m.client.Stop()
 		cancel()
 	}()
 
@@ -235,10 +235,10 @@ func (m *Server) handleStop(ctx context.Context, req *mcp.CallToolRequest, input
 func (m *Server) handleStatus(ctx context.Context, req *mcp.CallToolRequest, input struct{}) (*mcp.CallToolResult, StatusOutput, error) {
 	statuses, err := m.client.StatusSync(5 * time.Second)
 	if err != nil {
-		return nil, StatusOutput{}, err
+		return nil, StatusOutput{Services: []ServiceStatus{}}, err
 	}
 
-	var result []ServiceStatus
+	result := make([]ServiceStatus, 0, len(statuses))
 	for _, s := range statuses {
 		result = append(result, ServiceStatus{
 			Name:    s.Name,

internal/tui/model.go

@@ -81,7 +81,7 @@ func NewWithClient(client *daemon.Client, services []string, cfg *config.Config)
 func (m Model) Init() tea.Cmd {
 	if m.clientMode {
 		// Request initial status
-		m.client.Status()
+		_ = m.client.Status()
 		return tickCmd()
 	}
 
@@ -121,7 +121,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 			case "q", "ctrl+c":
 				m.quitting = true
 				if m.clientMode {
-					m.client.Stop()
+					_ = m.client.Stop()
 				} else {
 					m.Runner.Stop()
 				}
@@ -160,7 +160,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 			case "r":
 				if m.activeTab >= 0 && m.activeTab < len(m.services) {
 					if m.clientMode {
-						m.client.Restart(m.services[m.activeTab])
+						_ = m.client.Restart(m.services[m.activeTab])
 					} else {
 						m.Runner.RestartService(m.services[m.activeTab])
 					}
@@ -217,7 +217,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		if m.clientMode {
 			m.collectClientLogs()
 			// Periodically request status
-			m.client.Status()
+			_ = m.client.Status()
 		} else {
 			m.collectLogs()
 		}
@@ -247,7 +247,8 @@ func (m *Model) collectClientLogs() {
 	for {
 		select {
 		case msg := <-m.client.Receive():
-			if msg.Type == daemon.MsgLogEntry {
+			switch msg.Type {
+			case daemon.MsgLogEntry:
 				logData, err := daemon.ParsePayload[daemon.LogEntryData](msg)
 				if err == nil {
 					m.logs = append(m.logs, types.LogEntry{
@@ -260,7 +261,7 @@ func (m *Model) collectClientLogs() {
 						m.logs = m.logs[len(m.logs)-2000:]
 					}
 				}
-			} else if msg.Type == daemon.MsgStatusResponse {
+			case daemon.MsgStatusResponse:
 				resp, _ := daemon.ParsePayload[daemon.StatusResponse](msg)
 				for _, s := range resp.Services {
 					m.statuses[s.Name] = s

playground/.claude/settings.local.json

@@ -3,7 +3,8 @@
     "allow": [
       "mcp__devir__devir_status",
       "mcp__devir__devir_start",
-      "mcp__devir__devir_restart"
+      "mcp__devir__devir_restart",
+      "mcp__devir__devir_stop"
     ]
   },
   "enableAllProjectMcpServers": true,