BootstrapButton needs to use data-bs-target when GriddlyCss is Boostrap5

[nickdevore]

I'm attempting to use a button to open a modal. I'm using bootstrap 5 which requires the new data-bs-target attribute. I'm providing a PR to resolve this

[nickdevore]

Also, line 96 in Griddly/Views/Shared/Griddly/BootstrapButton.cshml looks like this

@Html.AttributeIf(css.Is(CssFramework.Bootstrap3, CssFramework.Bootstrap4) || button.Action != GriddlyButtonAction.Modal ? "data-toggle" : "data-bs-toggle", button.Action != GriddlyButtonAction.Navigate && button.Action != GriddlyButtonAction.Javascript, button.Action.ToString().ToLower())

...but is not putting the data-bs-toggle when CssFramework is Bootstrap5 because of the || condition. It is leaving it as data-toggle which then doesn't fire when the button type is ajax. Shouldn't the || condition of it being a Modal action be removed? Shouldn't it always be data-bs-toggle when it's bootstrap5?

I put this here because it is so closely related to the original problem. @programcsharp any thoughts?

[nickdevore]

...and I just discovered that if that change is made, then griddly.js is going to need the following to handle when buttons are on a page vs inside a griddly

GriddlyButton.handleClick = $.proxy(function (event)
{
    var button = $(event.currentTarget);

    if (button.hasClass("disabled"))
        return false;

    var griddly = button.closest("[data-role=griddly]");
    var url = button.data("url");
    var toggle = button.data("toggle") ?? button.data("bs-toggle");

.... lots more code

}

[programcsharp]

Wow, blast from the past, it's been a minute!

The suggestion looks right, looks like it might have been a copy/paste or merge issue.

@jehhynes any reason we shouldn't do it this way?

[jehhynes]

Looks like Joel intentionally implemented it that way. This is his commit message: "Use data-bs-toggle for modal actions in bs5" - so he meant to only update it for modals.

I'm fine with the suggestion, but be sure to update the .NET Core side as well.