-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3266 #3267
Issue 3266 #3267
Conversation
Update lesson to refer to Google Colab rather than Kaggle
Update to refer to Google Colab notebook instead of Kaggle
…-deep-learning-pt1-01.png
Fix link to notebook
Fix notebook links to include nbviewer
Fix notebook link to include nbviewer
Hello @hawc2, Daniel @davanstrien has very kindly provided us with a revised version of the codebook associated with We’ve now uploaded it to our organisationally hosted Colab space. @charlottejmc and I have made some additional adjustments to the codebook so that it consists of the code + essential line comments only, headings and subheadings that mirror the lesson, and does not extend or replicate the lesson’s commentary. (You’ll remember that one codebook is linked to both parts of the lesson). We’ve also prepared a first draft of revisions to the original EN lesson which you can review in Thank you. |
Hi @davanstrien, Thanks again for your patience as we make these changes. I've tried to ensure my edits are accurate, but please do carefully review them and flag anything that doesn't seem right to you.
I have chosen to add this in to the notebook, but please let me know if it needs to be removed.
|
Great, thanks everyone for this big improvement to the code for the lesson! |
Thank you for approving this, @hawc2. I've written to Daniel to ask if he can advise on the two small queries raised above. But if you're happy as things are, we could make those tweaks at a later date (if necessary)? |
oh ok @anisa-hawes yeah let's make those changes first if possible |
Hello @davanstrien and @kasparvonbeelen, As I mentioned in my email, when migrating the codebook which accompanies this lesson from Kaggle to Colab, we noted a few points of query which we'd like to ask for your advice on:
You can review a full preview of the revised lesson here, and review the revised codebook as it will be here. We're grateful for your help to resolve these queries. Your lessons have proved popular with our community, and we're excited to have received proposals for potential translations into Spanish and French 🙂 |
Following @anisa-hawes' comment, I've done a bit more investigating and we both agree on my findings:
|
Merging this PR with @hawc2's approval. @davanstrien and @kasparvonbeelen, if you find anything that still needs to be changed, please do let us know and I will reopen a branch. |
I have suggested some changes to the lesson text, to reflect the fact that readers are now using the accompanying Jupyter Notebook on Google Colab rather than on Kaggle, as was originally the case.
The biggest change was the
### Kaggle section
(now ### Google Colab), which I have updated to ensure the instructions are now relevant to Colab.Closes #3266
Checklist
Closes #ISSUENUMBER
to your summary above[ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.