Skip to content

Conversation

@sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Nov 29, 2023

Issue link

Fixes #18

What changes have been made

Create dedicated KinD composite action.

Verification steps

Use new action based on instructions in readme.
Tested in https://github.com/sutaakar/codeflare-operator/actions/runs/7034651607/job/19143190536

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [astefanutti,sutaakar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astefanutti
Copy link
Contributor

Awesome!

@openshift-merge-bot openshift-merge-bot bot merged commit 10834f8 into project-codeflare:main Nov 29, 2023
@sutaakar sutaakar deleted the kind branch November 30, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create dedicated KinD composite action

2 participants