-
Notifications
You must be signed in to change notification settings - Fork 59
refactor: use digest instead of tag for raycluster image #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use digest instead of tag for raycluster image #396
Conversation
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the SHA 👍 . The unit-tests are failing, but I think you just need to update this line on the test:
codeflare-sdk/tests/unit_test.py
Line 245 in 9380986
| assert config.image == "quay.io/project-codeflare/ray:latest-py39-cu118" |
71e0ff1 to
4b2ff50
Compare
|
Do a |
4b2ff50 to
080c5a4
Compare
|
Based on the unit-tests that are failing (3 of them), these files need to be updated with the SHA as well:
Note that each file has two |
tedhtchang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tedhtchang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/LGTM cancel |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue link
What changes have been made
Changing from tag to digest reference for raycluster image
Verification steps
Confirm that the sha matches the sha from the latest raycluster tag here
Checks