-
Notifications
You must be signed in to change notification settings - Fork 59
Added RayJobSubmission Client wrapper for RCS not created by CodeFlare #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RayJobSubmission Client wrapper for RCS not created by CodeFlare #415
Conversation
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Mark! I left a few requested changes below. Apart from those, I noticed there are some functions that are not unit tested, is there a reason for that? Just thinking about code coverage.
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm thanks!
KPostOffice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Just some styling and docs nitpicks
14f979d to
9f9acc3
Compare
|
@KPostOffice Added in the param descriptions from the ray docs and Changed the |
KPostOffice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria, KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Closes: #410
What changes have been made
Added the
RayJobClientobject for use of RayJobSubmission related commands with the SDK.This allows us to leverage the SDK to submit jobs to Ray Clusters that were either not created by the SDK or are in a non Kubernetes environment.
Verification steps
Checks