Added directory creation check for cases where mcad=False #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
approved these changes
Jan 22, 2024
Contributor
astefanutti
left a comment
astefanutti
left a comment
There was a problem hiding this comment.
Can we also make it so the directory is renamed to something different from appwrapper in a follow up PR?
Fiona-Waters
approved these changes
Jan 22, 2024
Contributor
Fiona-Waters
left a comment
Fiona-Waters
left a comment
There was a problem hiding this comment.
Ran through verification steps and directory is created as expected.
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, Fiona-Waters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Added a conditional statement that will create the
~/.codeflare/appwrapperdirectory if it doesn't exist for thewrite_components()function.Verification steps
Ensure the
~/.codeflare/appwrapperdirectory does not existRun poetry build on the PR changes and install the whl file
Run through an SDK demo notebook but set
mcad=Falsein the cluster configuration.The folder and yaml file should be present at
~/.codeflare/appwrapperChecks