Skip to content

[WIP] Added mcad bool for Job submission with no cluster #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP] Added mcad bool for Job submission with no cluster #460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22f8bcd
Added mcad bool for Job submission with no cluster
Bobbins228 Feb 14, 2024
cbba3bb
Updated scheduler name
Bobbins228 Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/codeflare_sdk/job/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def __init__(
scheduler_args: Optional[Dict[str, str]] = None,
image: Optional[str] = None,
workspace: Optional[str] = f"file://{Path.cwd()}",
mcad: Optional[str] = False,
):
if bool(script) == bool(m): # logical XOR
raise ValueError(
Expand All @@ -93,6 +94,7 @@ def __init__(
)
self.image = image
self.workspace = workspace
self.mcad = mcad

def _dry_run(self, cluster: "Cluster"):
j = f"{cluster.config.num_workers}x{max(cluster.config.num_gpus, 1)}" # # of proc. = # of gpus
Expand Down Expand Up @@ -136,6 +138,9 @@ def _dry_run_no_cluster(self):
if self.scheduler_args is not None:
if self.scheduler_args.get("namespace") is None:
self.scheduler_args["namespace"] = get_current_namespace()
scheduler = "kueue"
if self.mcad == True:
scheduler = "kubernetes_mcad"
runner = get_runner()
return (
runner.dryrun(
Expand Down Expand Up @@ -172,7 +177,7 @@ def _dry_run_no_cluster(self):
if self.image is not None
else self._missing_spec("image"),
),
scheduler="kubernetes_mcad",
scheduler=scheduler,
cfg=self.scheduler_args,
workspace="",
),
Expand Down