Set Cluster Configuration to operate in memory by default

[Bobbins228]

Issue link

RHOAIENG-4525

What changes have been made

By default the SDK now handles appwrapper/individual-resource creation in memory.
Yaml files are not generated while write_to_file=False in cluster configuration

Verification steps

Setup

Notebook server ODH/RHOAI/Local

• Clone this repository with git clone https://github.com/project-codeflare/codeflare-sdk.git
• Checkout this PR's branch
• Run poetry build - install if needed (pip install poetry)
• Run pip install --force-reinstall dist/codeflare_sdk-0.0.0.dev0-py3-none-any.whl
• Restart your notebook kernel

Testing

This is very tedious to test as there are 4 possible ways of creating a cluster config with this change. i.e. (mcad=False, write_to_file=False), (mcad=True, write_to_file=False), ...

I recommend to start by testing mcad=True/False with write_to_file=False

• Delete your ~/.codeflare folder - Not necessary but easier to catch things working incorrectly.
• Follow a demo notebook of your choosing
• Run ClusterConfiguration and a yaml/appwrapper file will not be written you should receive a message like this Yaml resources loaded for <cluster-name>
• Continue to run through the demo notebook
  Repeat with an alternate mix of the variables.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[VanillaSpoon]

Ran through a demo notebook testing each of the expected outputs as well as default, everything is going smoothly :) code changes look good too.

/lgtm

One thing though, should an explanation be added within docs/cluster-configuration.md?

[Bobbins228]

@VanillaSpoon
Thanks Eoin!

One thing though, should an explanation be added within docs/cluster-configuration.md?

I plan to make an addition to the cluster config docs after a new release 👍

[KPostOffice]

Looks good. One small comment

[Fiona-Waters]

Successfully ran through all 4 scenarios. All works as expected. Love this addition, great work Mark!
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Fiona-Waters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment