-
Notifications
You must be signed in to change notification settings - Fork 58
Merge RayJobs Feature Branch to main #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Co-authored-by: Pat O'Connor <paoconno@redhat.com>
1a61bfd
to
0dece2a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 92.47% 94.24% +1.77%
==========================================
Files 25 24 -1
Lines 1395 2033 +638
==========================================
+ Hits 1290 1916 +626
- Misses 105 117 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kryanbeane a few questions/comments inline.
I have no objection to this merging and addressing those in a seperate pr if needed.
/approve |
@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: report In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: laurafitzgerald The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
https://issues.redhat.com/browse/RHOAIENG-25146
What changes have been made
Merging the RayJobs feature branch to main
Verification steps
Checks