Skip to content

Conversation

kryanbeane
Copy link
Contributor

@kryanbeane kryanbeane commented Oct 14, 2025

Issue link

https://issues.redhat.com/browse/RHOAIENG-25146

What changes have been made

Merging the RayJobs feature branch to main

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2025
kryanbeane and others added 26 commits October 15, 2025 11:41
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Signed-off-by: Pat O'Connor <paoconno@redhat.com>
Co-authored-by: Pat O'Connor <paoconno@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2025
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 97.32541% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.24%. Comparing base (d23d5fd) to head (185dcac).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
src/codeflare_sdk/ray/rayjobs/rayjob.py 97.14% 6 Missing ⚠️
src/codeflare_sdk/common/utils/validation.py 85.71% 5 Missing ⚠️
src/codeflare_sdk/ray/rayjobs/config.py 97.57% 4 Missing ⚠️
src/codeflare_sdk/ray/cluster/cluster.py 81.81% 2 Missing ⚠️
src/codeflare_sdk/ray/rayjobs/runtime_env.py 99.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   92.47%   94.24%   +1.77%     
==========================================
  Files          25       24       -1     
  Lines        1395     2033     +638     
==========================================
+ Hits         1290     1916     +626     
- Misses        105      117      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kryanbeane a few questions/comments inline.
I have no objection to this merging and addressing those in a seperate pr if needed.

@laurafitzgerald
Copy link
Contributor

/approve
/lgtm
final comments can be addressed in follow up pr.
/override report

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

@laurafitzgerald: Overrode contexts on behalf of laurafitzgerald: report

In response to this:

/approve
/lgtm
final comments can be addressed in follow up pr.
/override report

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@laurafitzgerald laurafitzgerald self-requested a review October 15, 2025 15:21
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
@laurafitzgerald
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2025
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c3b831a into main Oct 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants