Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage-badge.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
poetry install --with test
- name: Generate coverage report
run: |
coverage run --omit="src/**/test_*.py,src/codeflare_sdk/common/utils/unit_test_support.py" -m pytest
coverage run --omit="src/**/test_*.py,src/codeflare_sdk/common/utils/unit_test_support.py,src/codeflare_sdk/vendored/**" -m pytest

- name: Coverage Badge
uses: tj-actions/coverage-badge-py@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
poetry install --with test
- name: Test with pytest and check coverage
run: |
coverage run --omit="src/**/test_*.py,src/codeflare_sdk/common/utils/unit_test_support.py" -m pytest
coverage run --omit="src/**/test_*.py,src/codeflare_sdk/common/utils/unit_test_support.py,src/codeflare_sdk/vendored/**" -m pytest
coverage=$(coverage report -m | tail -1 | tail -c 4 | head -c 2)
if (( $coverage < 90 )); then echo "Coverage failed at ${coverage}%"; exit 1; else echo "Coverage passed, ${coverage}%"; fi
- name: Upload to Codecov
Expand Down
22 changes: 1 addition & 21 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ description = "Python SDK for codeflare client"

license = "Apache-2.0"

# Exclude vendored tests, examples, and build files from the package
exclude = [
"src/codeflare_sdk/vendored/python_client_test",
"src/codeflare_sdk/vendored/examples",
"src/codeflare_sdk/vendored/pyproject.toml",
"src/codeflare_sdk/vendored/poetry.lock",
"src/codeflare_sdk/vendored/README.md"
]

authors = [
"Michael Clifford <mcliffor@redhat.com>",
"Mustafa Eyceoz <meyceoz@redhat.com>",
Expand All @@ -33,7 +42,6 @@ cryptography = "43.0.3"
executing = "1.2.0"
pydantic = ">= 2.10.6"
ipywidgets = "8.1.2"
python-client = { git = "https://github.com/ray-project/kuberay.git", subdirectory = "clients/python-client", rev = "b2fd91b58c2bbe22f9b4f730c5a8f3180c05e570" }

[[tool.poetry.source]]
name = "pypi"
Expand Down Expand Up @@ -73,7 +81,7 @@ markers = [
"openshift",
"nvidia_gpu"
]
addopts = "--timeout=900"
addopts = "--timeout=900 --ignore=src/codeflare_sdk/vendored"
testpaths = ["src/codeflare_sdk"]
collect_ignore = ["src/codeflare_sdk/common/utils/unit_test_support.py"]

Expand Down
4 changes: 2 additions & 2 deletions src/codeflare_sdk/ray/rayjobs/rayjob.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
from codeflare_sdk.common.utils.constants import MOUNT_PATH

from codeflare_sdk.common.utils.utils import get_ray_image_for_python_version
from python_client.kuberay_job_api import RayjobApi
from python_client.kuberay_cluster_api import RayClusterApi
from codeflare_sdk.vendored.python_client.kuberay_job_api import RayjobApi
from codeflare_sdk.vendored.python_client.kuberay_cluster_api import RayClusterApi
from codeflare_sdk.ray.rayjobs.config import ManagedClusterConfig
from codeflare_sdk.ray.rayjobs.runtime_env import (
create_file_secret,
Expand Down
35 changes: 35 additions & 0 deletions src/codeflare_sdk/vendored/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@



# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
*$py.class


# Distribution / packaging
bin/
build/
develop-eggs/
dist/
eggs/
lib/
lib64/
parts/
sdist/
var/
*.egg-info/
.installed.cfg
*.egg

# Installer logs
pip-log.txt
pip-delete-this-directory.txt

# Unit test / coverage reports
.tox/
htmlcov
.coverage
.cache
nosetests.xml
coverage.xml
Loading
Loading