Skip to content

Conversation

@pawelpaszki
Copy link
Contributor

Issue link

RHOAIENG-34273

What changes have been made

GH action to build and push e2e test images

Verification steps

Visually compare against midstream kuberay and check that the GH action secrets exist and their names match these in the added GH action

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 24, 2025

@pawelpaszki: This pull request references RHOAIENG-34273 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Issue link

RHOAIENG-34273

What changes have been made

GH action to build and push e2e test images

Verification steps

Visually compare against midstream kuberay and check that the GH action secrets exist and their names match these in the added GH action

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawelpaszki pawelpaszki marked this pull request as ready for review November 24, 2025 12:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (1e094f1) to head (27fe5db).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #945   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          24       24           
  Lines        2096     2096           
=======================================
  Hits         1973     1973           
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LilyLinh
Once this PR has been reviewed and has the lgtm label, please assign laurafitzgerald for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawelpaszki pawelpaszki merged commit 8eac545 into project-codeflare:main Nov 24, 2025
13 of 15 checks passed
@pawelpaszki pawelpaszki deleted the RHOAIENG-34273 branch November 24, 2025 13:58
pawelpaszki added a commit to pawelpaszki/codeflare-sdk that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants