ci: add go 1.18 to CI #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that there *is* motivation for keeping golang 1.17 around: golangci-lint only runs certain linters with golang 1.18 right now, because generics broke the AST apparently. So, let's keep 1.17 around and make sure that those linters still run, since eventually they'll be re-enabled and this way we won't have to go through and fix everything when they are. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that there is motivation for keeping golang 1.17 around:
golangci-lint only runs certain linters with golang 1.18 right now,
because generics broke the AST apparently.
So, let's keep 1.17 around and make sure that those linters still run,
since eventually they'll be re-enabled and this way we won't have to go
through and fix everything when they are.
Signed-off-by: Tycho Andersen tycho@tycho.pizza