publish: added skip-tls flag for uploading to a insecure http registry #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
force-pushed
the
publish_http
branch
2 times, most recently
from
848a4a9 to
731e8bb
Compare
|
I don't suppose there's an easy way to write a test for this is there? |
|
We can have an env variable which points to a registry. If variable not set we skip those tests. I will update |
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
force-pushed
the
publish_http
branch
from
731e8bb to
3950e22
Compare
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
force-pushed
the
publish_http
branch
from
3950e22 to
0d47e5c
Compare
|
need to test it locally, I will update the status |
|
tested locally, all good, it's ready for review. |
|
Looks good to me, thanks! I'll push a release shortly to test that pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petu Eusebiu peusebiu@cisco.com