build: switch the default shell to /usr/bin/sh #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem here is as follows: 1. user deletes the /bin -> /usr/bin symlink (e.g. via tar command without --keep-directory-symlink or an rsync without --keep-dirlinks) 2. layer is created 3. build on top of that layer fails because /bin doesn't have sh in it any more. Both centos7 and ubuntu have this /bin -> /usr/bin construction, so let's default to that. Of course, because everything is wonderful, alpine only ships /bin/sh, and does not have a /usr/bin -> /bin symlink, so stacker's own build breaks without explicit shebangs. But best to use what downstream users expect. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
rchamarthy
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is as follows:
--keep-directory-symlink or an rsync without --keep-dirlinks)
more.
Both centos7 and ubuntu have this /bin -> /usr/bin construction, so let's
default to that.
Of course, because everything is wonderful, alpine only ships /bin/sh, and
does not have a /usr/bin -> /bin symlink, so stacker's own build breaks
without explicit shebangs. But best to use what downstream users expect.
Signed-off-by: Tycho Andersen tycho@tycho.pizza