doc: updated dependencies for first time build #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tych0
reviewed
Apr 26, 2022
doc/install.md
Outdated
| libsquash from squash-tools-ng need to be installed globally, as user specific | ||
| path overrides aren't propagated into `make check`'s test envs. | ||
|
|
||
| `make check` also requires the golangci-lint to be installed in /bin |
There was a problem hiding this comment.
really it's just your $GOPATH/bin here right? https://github.com/project-stacker/stacker/blob/master/Makefile#L41
There was a problem hiding this comment.
That is correct. I remember inertially putting it in /bin and then I saw the message in the console, moved it to $GOPATH/bin and it worked, but forgot to write that in my notes. I'll update the PR in a moment
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
chofnar
force-pushed
the
updateDependencies
branch
from
e2a1c65 to
b9e23cd
Compare
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Catalin Hofnar catalin.hofnar@gmail.com