Added a flag to specify OCI annotation namespace #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
force-pushed
the
annotation_namespace
branch
2 times, most recently
from
99a12c8 to
b98b730
Compare
rchincha
reviewed
May 9, 2022
api.go
Outdated
| const ( | ||
| GitVersionAnnotation = "com.cisco.stacker.git_version" | ||
| StackerContentsAnnotation = "com.cisco.stacker.stacker_yaml" | ||
| GitVersionAnnotation = "com.%s.stacker.git_version" |
There was a problem hiding this comment.
remove the "com." as well
For example, this would "io.zotregistry.stacker.git_version"
There was a problem hiding this comment.
Thinking about this some more. Do we want to just default this to "io.project-stacker.stacker.git_version"
There was a problem hiding this comment.
"io.stackeroci.stacker.git_version"
There was a problem hiding this comment.
ok, sure
eusebiu-constantin-petu-dbk
force-pushed
the
annotation_namespace
branch
2 times, most recently
from
e81fad9 to
7b407a2
Compare
andaaron
approved these changes
Jun 7, 2022
eusebiu-constantin-petu-dbk
force-pushed
the
annotation_namespace
branch
from
7b407a2 to
e128c8c
Compare
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
eusebiu-constantin-petu-dbk
force-pushed
the
annotation_namespace
branch
from
e128c8c to
c495ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added --annotations-namespace arg
Signed-off-by: Petu Eusebiu peusebiu@cisco.com