feat: use creds from auth.json for imports #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemccracken
requested review from
hallyn,
rchincha and
smoser
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
- Coverage 60.51% 60.41% -0.11%
==========================================
Files 59 59
Lines 6461 6477 +16
==========================================
+ Hits 3910 3913 +3
- Misses 1906 1916 +10
- Partials 645 648 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rchincha
reviewed
Aug 12, 2025
test/import-http-auth.bats
Outdated
| url: ${{BUSYBOX_OCI}} | ||
| imports: | ||
| - path: http://localhost:9999/importme | ||
| credential: mytestcredential |
There was a problem hiding this comment.
What does this ("credential") do? From code, it looks like we are just using hostname as the key to lookup credentials?
There was a problem hiding this comment.
good catch, thanks - that was from an earlier approach. I'll remove this
Adds support for authenticating to http servers using basic auth by checking for matching credentials in the containers/auth.json file supported by the containers/image library for use in authenticating to registries. Signed-off-by: Michael McCracken <mikmccra@cisco.com>
mikemccracken
force-pushed
the
2025.08.11/main/creds-import
branch
from
e5bb0fa to
0f10ac2
Compare
hallyn
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for authenticating to http servers using basic auth by checking for matching credentials in the containers/auth.json file supported by the containers/image library for use in authenticating to registries.
What type of PR is this?
This is a feature PR!
Which issue does this PR fix:
Fixes #710
What does this PR do / Why do we need it:
allows importing from authenticated hosts! we need that!
Testing done on this change:
See the test added in CI
Automation added to e2e:
none
Will this break upgrades or downgrades?
no, no change to CLI or stackerfile format!
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
You bet I do ✅