This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Atomic/util.py: Use tls-verify on skopeo subcommands#1072
Closed
baude wants to merge 1 commit intoprojectatomic:masterfrom
Closed
Atomic/util.py: Use tls-verify on skopeo subcommands#1072baude wants to merge 1 commit intoprojectatomic:masterfrom
baude wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
rhatdan
reviewed
Aug 17, 2017
Atomic/util.py
Outdated
| args=[] | ||
|
|
||
| cmd = [SKOPEO_PATH, 'tls-verify=false', 'delete'] + args + [image] | ||
| cmd = [SKOPEO_PATH, 'delete', 'tls-verify=false'], + args + [image] |
Member
There was a problem hiding this comment.
Shouldn't this be --tls-verify?
baude
force-pushed
the
tls_verify_skopeo
branch
from
7a08896 to
50adf2d
Compare
In order to avoid warnings from skopeo, we should be using tls-verify on the skopeo subcommand (like copy) rather than skopeo itself. This was reported in issue projectatomic#1067.
baude
force-pushed
the
tls_verify_skopeo
branch
from
50adf2d to
0aad9de
Compare
Member
|
💔 Test failed - status-redhatci |
Member
|
@baude Tests failed? |
Member
Author
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-redhatci |
eyusupov
pushed a commit
to eyusupov/atomic
that referenced
this pull request
Mar 10, 2018
In order to avoid warnings from skopeo, we should be using tls-verify on the skopeo subcommand (like copy) rather than skopeo itself. This was reported in issue projectatomic#1067. Closes: projectatomic#1072 Approved by: rhatdan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to avoid warnings from skopeo, we should be using
tls-verify on the skopeo subcommand (like copy) rather than
skopeo itself.
This was reported in issue #1067.
Related Issue Numbers
Pull Request Checklist:
If your Pull request contains new features or functions, tests are required. If the PR is a bug fix and no tests exist, please consider adding some to prevent regressions.