This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Append command to container run method when container is not running.#110
Merged
rhatdan merged 1 commit intoprojectatomic:masterfrom Aug 10, 2015
Merged
Append command to container run method when container is not running.#110rhatdan merged 1 commit intoprojectatomic:masterfrom
rhatdan merged 1 commit intoprojectatomic:masterfrom
Conversation
Member
Author
|
@aweiteka Does this work for you? @willmtemple @cgwalters @sctweedie Please review. |
Contributor
|
@rhatdan that's it. Simple as that. Thanks. |
|
@rhatdan I checked this out locally for tests, and I'm getting an error in It looks like the error is that this PR doesn't include #109, but GitHub hasn't figured out that this branch is out-of date. I think if you merge changes from master into this PR it should be good. |
We have two cases when calling atomic run, In one case the container
exists and we will just execute the COMMAND into the container.
If the container is not running, we want to append the COMMAND onto the
container RUN method, to allow more complex interaction.
For example if i had container image TEST that had the run label:
LABEL RUN="docker run -ti \${IMAGE} command"
atomic run TEST -h
Would execute
docker run -ti \${IMAGE} command -h
Displaying help information about the container.
Member
Author
|
@willmtemple Please check it again. Docker is hosed up on my machine right now, so I can not test. I don't see this happening with the current code. |
|
@rhatdan LGTM |
rhatdan
added a commit
that referenced
this pull request
Aug 10, 2015
Append command to container run method when container is not running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two cases when calling atomic run, In one case the container
exists and we will just execute the COMMAND into the container.
If the container is not running, we want to append the COMMAND onto the
container RUN method, to allow more complex interaction.
For example if i had container image TEST that had the run label:
LABEL RUN="docker run -ti ${IMAGE} command"
atomic run TEST -h
Would execute
docker run -ti ${IMAGE} command -h
Displaying help information about the container.