This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Atomic/backends/_containers_storage.py: stop#1100
Closed
baude wants to merge 1 commit intoprojectatomic:masterfrom
Closed
Atomic/backends/_containers_storage.py: stop#1100baude wants to merge 1 commit intoprojectatomic:masterfrom
baude wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
Member
|
LGTM |
|
|
||
| def stop_container(self, con_obj, **kwargs): | ||
| raise UnderDevelopment() | ||
| # If we plant to honor stop labels here, we will |
There was a problem hiding this comment.
nit, "plant to" to "plan to" or just drop both words and go to "If we honor stop..."
TomSweeneyRedHat
left a comment
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
Code changes LGTM, but tests aren't hip at the moment.
Member
Author
|
bot, retest this please |
2 similar comments
Member
Author
|
bot, retest this please |
Member
Author
|
bot, retest this please |
Implement stop for a container.
Member
Author
|
bot, retest this please |
Member
Author
Member
Author
|
☀️ Test successful - status-redhatci |
eyusupov
pushed a commit
to eyusupov/atomic
that referenced
this pull request
Mar 10, 2018
Implement stop for a container. Closes: projectatomic#1100 Approved by: baude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement stop for a container.
Description
Related Bugzillas
Related Issue Numbers
Pull Request Checklist:
If your Pull request contains new features or functions, tests are required. If the PR is a bug fix and no tests exist, please consider adding some to prevent regressions.