Skip to content
This repository was archived by the owner on Oct 10, 2020. It is now read-only.

syscontainers: cleanup on GLib.Error#1116

Closed
giuseppe wants to merge 2 commits intoprojectatomic:masterfrom
giuseppe:syscontainers-catch-gliberror-on-install
Closed

syscontainers: cleanup on GLib.Error#1116
giuseppe wants to merge 2 commits intoprojectatomic:masterfrom
giuseppe:syscontainers-catch-gliberror-on-install

Conversation

@giuseppe
Copy link
Collaborator

@giuseppe giuseppe commented Oct 12, 2017

This is the exception type raised by OSTree if the checkout fails. I've
observed while running out of space on /var and the installation left
the incomplete checkout for the container.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@giuseppe
Copy link
Collaborator Author

@rh-atomic-bot delegate=ashcrow

@rh-atomic-bot
Copy link

✌️ @ashcrow can now approve this pull request

@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2017

Failing based on:

E:535,16: Catching an exception which doesn't inherit from Exception: Error (catching-non-exception)
E:551,12: Raising a new style class which doesn't inherit from BaseException (raising-non-exception)

These should be added to the two disable lists in the Makefile.

  • catching-non-exception
  • raising-non-exception

@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2017

Failure is unrelated to this PR

Running test_storage.sh....                     FAIL

@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2017

@rh-atomic-bot r+ fcd4ac2

@rh-atomic-bot
Copy link

⌛ Testing commit fcd4ac2 with merge 7aab430...

rh-atomic-bot pushed a commit that referenced this pull request Oct 12, 2017
This is the exception type raised by OSTree if the checkout fails.  I've
observed while running out of space on /var and the installation left
the incomplete checkout for the container.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1116
Approved by: ashcrow
@jlebon
Copy link
Contributor

jlebon commented Oct 12, 2017

This needs to be merged in first: #1106. Feel free to r+ it if it looks sane to you!

@rh-atomic-bot
Copy link

💔 Test failed - status-papr

@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2017

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit fcd4ac2 with merge 76c0e9a...

rh-atomic-bot pushed a commit that referenced this pull request Oct 12, 2017
This is the exception type raised by OSTree if the checkout fails.  I've
observed while running out of space on /var and the installation left
the incomplete checkout for the container.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: #1116
Approved by: ashcrow
This is the exception type raised by OSTree if the checkout fails.  I've
observed while running out of space on /var and the installation left
the incomplete checkout for the container.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the syscontainers-catch-gliberror-on-install branch from fcd4ac2 to f477c2f Compare October 12, 2017 14:37
@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2017

@rh-atomic-bot r+ fcd4ac2

@rh-atomic-bot
Copy link

🙀 fcd4ac2 is not a valid commit SHA. Please try again with f477c2f.

@ashcrow
Copy link
Contributor

ashcrow commented Oct 12, 2017

@rh-atomic-bot r+ f477c2f

@rh-atomic-bot
Copy link

⚡ Test exempted: pull fully rebased and already tested.

eyusupov pushed a commit to eyusupov/atomic that referenced this pull request Mar 10, 2018
This is the exception type raised by OSTree if the checkout fails.  I've
observed while running out of space on /var and the installation left
the incomplete checkout for the container.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

Closes: projectatomic#1116
Approved by: ashcrow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants