This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Conversation
Fix test failures that have crept into the atomic master.
tests/integration/test_display.sh
Fix failure related to defined UID/GID's in the test itself. I now
use sed to remove the --user UID:GID to make the comparison equal
and remove potential for dynamic failures.
I also had to add a conditional if the labels (in python) are of
type None to prevent a traceback.
tests/integration/test_info.sh
There seemed to be two related failures in the test case that relate to
running 'atomic info --remote'. If that command is run with a docker
daemon that is not capable of --remote, the test will failure. I added
a variable based on the return of that command and put it under the
set +e section.
I then added a conditional for that test (based on the return of above),
to only run the test if the docker daemon is capable of the --remote
function.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/integration/test_display.sh
Fix failure related to defined UID/GID's in the test itself. I now
use sed to remove the --user UID:GID to make the comparison equal
and remove potential for dynamic failures.
tests/integration/test_info.sh
There seemed to be two related failures in the test case that relate to
running 'atomic info --remote'. If that command is run with a docker
daemon that is not capable of --remote, the test will failure. I added
a variable based on the return of that command and put it under the
set +e section.