Skip to content
This repository was archived by the owner on Oct 10, 2020. It is now read-only.

FIX test failures#144

Merged
rhatdan merged 1 commit intoprojectatomic:masterfrom
baude:fix_tests
Sep 1, 2015
Merged

FIX test failures#144
rhatdan merged 1 commit intoprojectatomic:masterfrom
baude:fix_tests

Conversation

@baude
Copy link
Member

@baude baude commented Aug 31, 2015

Fix test failures that have crept into the atomic master.

tests/integration/test_display.sh
Fix failure related to defined UID/GID's in the test itself. I now
use sed to remove the --user UID:GID to make the comparison equal
and remove potential for dynamic failures.

I also had to add a conditional if the labels (in python) are of
type None to prevent a traceback.

tests/integration/test_info.sh
There seemed to be two related failures in the test case that relate to
running 'atomic info --remote'. If that command is run with a docker
daemon that is not capable of --remote, the test will failure. I added
a variable based on the return of that command and put it under the
set +e section.

I then added a conditional for that test (based on the return of above),
to only run the test if the docker daemon is capable of the --remote
function.

    Fix test failures that have crept into the atomic master.

tests/integration/test_display.sh
    Fix failure related to defined UID/GID's in the test itself.  I now
    use sed to remove the --user UID:GID to make the comparison equal
    and remove potential for dynamic failures.

    I also had to add a conditional if the labels (in python) are of
    type None to prevent a traceback.

tests/integration/test_info.sh
    There seemed to be two related failures in the test case that relate to
    running 'atomic info --remote'.  If that command is run with a docker
    daemon that is not capable of --remote, the test will failure.  I added
    a variable based on the return of that command and put it under the
    set +e section.

    I then added a conditional for that test (based on the return of above),
    to only run the test if the docker daemon is capable of the --remote
    function.
@rhatdan
Copy link
Member

rhatdan commented Sep 1, 2015

LGTM

rhatdan added a commit that referenced this pull request Sep 1, 2015
@rhatdan rhatdan merged commit 1133d8d into projectatomic:master Sep 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants