Skip to content
This repository was archived by the owner on Oct 10, 2020. It is now read-only.

Add missing ostree options#167

Merged
rhatdan merged 1 commit intoprojectatomic:masterfrom
rhatdan:ostree
Sep 28, 2015
Merged

Add missing ostree options#167
rhatdan merged 1 commit intoprojectatomic:masterfrom
rhatdan:ostree

Conversation

@rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 23, 2015

No description provided.

@rhatdan
Copy link
Member Author

rhatdan commented Sep 23, 2015

@cgwalters @dustymabe PTAL

Should I also add the --version?

@dustymabe
Copy link
Contributor

This may be a bad idea but is it possible to "collect" all options that atomic cli doesn't know about and simply pass them through to rpm-ostree. If it's a bad option rpm-ostree will complain about it. Would this be better than having to maintain the options in two places?

If this is a good idea then it is also something we could implement down the road and accept this PR the way it is for now.

@cgwalters
Copy link
Member

I would lean a bit towards maybe only supporting the "common" options like --allow-downgrade - people who are using --sysroot are doing pretty advanced things.

That said, no objections to the patch as is too.

(Long term, I think we could support scraping the options dynamically, or just use rpm-ostree as a shared library)

@rhatdan
Copy link
Member Author

rhatdan commented Sep 23, 2015

I took a quick look to see if there was a way to handle options that the command did not know about, but I found nothing.

We could add something like example something like this.

atomic host upgrade -- --foobar

And then pass the additional arguments to the command?

This would not show in atomic host upgrade --help
though.

@rhatdan
Copy link
Member Author

rhatdan commented Sep 28, 2015

Ok I am going to merge this patch. Should handle both cases.

rhatdan added a commit that referenced this pull request Sep 28, 2015
Add missing ostree options
@rhatdan rhatdan merged commit 0580e60 into projectatomic:master Sep 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants