This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Make test_display.sh pass again#173
Merged
rhatdan merged 1 commit intoprojectatomic:masterfrom Sep 24, 2015
jlebon:fix-integration-tests
Merged
Make test_display.sh pass again#173rhatdan merged 1 commit intoprojectatomic:masterfrom jlebon:fix-integration-tests
rhatdan merged 1 commit intoprojectatomic:masterfrom
jlebon:fix-integration-tests
Conversation
This patch makes test_display.sh pass. They are mostly tweaks to account for the following: - Account for commit 7858957, which removes {CONF,LOG,DATA}DIR from the target environment. - Account for commit ae931d0, which removes those default bind mounts. - Fix a few mismatches between the labels in the Dockerfile vs the expected output in the test script. And with that, all tests (should) pass!
Member
|
Thanks, sorry I missed this. LGTM |
rhatdan
added a commit
that referenced
this pull request
Sep 24, 2015
Make test_display.sh pass again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes test_display.sh pass. They are mostly tweaks to account
for the following:
target environment.
expected output in the test script.
And with that, all tests (should) pass!