Skip to content
This repository was archived by the owner on Oct 10, 2020. It is now read-only.

Let test.sh decide if bash, not Makefile#286

Merged
rhatdan merged 1 commit intoprojectatomic:masterfrom
cdrage:fix-makefile
Jan 19, 2016
Merged

Let test.sh decide if bash, not Makefile#286
rhatdan merged 1 commit intoprojectatomic:masterfrom
cdrage:fix-makefile

Conversation

@cdrage
Copy link
Member

@cdrage cdrage commented Jan 18, 2016

We should let test.sh decide whether to use bash or not, rather than Makefile.

Errors if not in sh / bash.

dropbox/dev/atomic  master ✔                                                                                                                                                                                                                              1d  
▶ sudo make test
sh ./test.sh
./test.sh: 2: set: Illegal option -o pipefail
Makefile:14: recipe for target 'test' failed
make: *** [test] Error 2

after PR:

dropbox/dev/atomic  fix-makefile ✔                                                                                                                                                                                                                        1m  
▶ sudo make test
./test.sh
Pulling standard images from Docker Hub...

@cdrage
Copy link
Member Author

cdrage commented Jan 18, 2016

Jenkins failed? :(

Some tests run in sh rather than bash?

@rhatdan
Copy link
Member

rhatdan commented Jan 19, 2016

LGTM

rhatdan added a commit that referenced this pull request Jan 19, 2016
Let test.sh decide if bash, not Makefile
@rhatdan rhatdan merged commit 958d939 into projectatomic:master Jan 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants