This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Let test.sh decide if bash, not Makefile#286
Merged
rhatdan merged 1 commit intoprojectatomic:masterfrom Jan 19, 2016
Merged
Conversation
Member
Author
|
Jenkins failed? :( Some tests run in sh rather than bash? |
Member
|
LGTM |
rhatdan
added a commit
that referenced
this pull request
Jan 19, 2016
Let test.sh decide if bash, not Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should let
test.shdecide whether to use bash or not, rather thanMakefile.Errors if not in sh / bash.
after PR: