This repository was archived by the owner on Oct 10, 2020. It is now read-only.
[merged] Atomic/diff.py: Do not hide SelectionMatchError and clean-up#368
Closed
baude wants to merge 1 commit intoprojectatomic:masterfrom
Closed
[merged] Atomic/diff.py: Do not hide SelectionMatchError and clean-up#368baude wants to merge 1 commit intoprojectatomic:masterfrom
baude wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
Atomic/diff.py
Outdated
|
|
||
| @staticmethod | ||
| def create_image_list(images): | ||
| def create_image_list(self, images): |
Member
There was a problem hiding this comment.
Why can't this stay a staticmethod and call helpers._cleanup(image_list)?
baude
force-pushed
the
atomic_diff_graceful_error
branch
from
312493d to
2840be5
Compare
Previously, the raise of SelectionMatchError was not getting to stderr so diff would fail silently. We now write the error to stderr and clean up any mounts and dm devices created.
baude
force-pushed
the
atomic_diff_graceful_error
branch
from
2840be5 to
f573361
Compare
Member
Author
|
fixed and passes tests |
Member
|
☀️ Test successful - status-atomicjenkins |
cgwalters-bot
changed the title
baude
added a commit
to baude/atomic
that referenced
this pull request
May 3, 2016
Previously, the raise of SelectionMatchError was not getting to stderr so diff would fail silently. We now write the error to stderr and clean up any mounts and dm devices created. Closes: projectatomic#368 Approved by: rhatdan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the raise of SelectionMatchError was not getting to
stderr so diff would fail silently. We now write the error to
stderr and clean up any mounts and dm devices created.