This repository was archived by the owner on Oct 10, 2020. It is now read-only.
[merged] System containers more tests#405
Closed
giuseppe wants to merge 4 commits intoprojectatomic:masterfrom
Closed
[merged] System containers more tests#405giuseppe wants to merge 4 commits intoprojectatomic:masterfrom
giuseppe wants to merge 4 commits intoprojectatomic:masterfrom
Conversation
| d = OSTreeMount(self.mountpoint, live=self.live, shared=self.shared) | ||
| if d.mount(self.image, self.options): | ||
| return | ||
|
|
Member
There was a problem hiding this comment.
Are you reverting a previous patch?
Collaborator
Author
There was a problem hiding this comment.
yes, I moved the failing exception after we check that there is a system container with that name. It is needed so I can properly show an error message when users specify --live or --shared with a system container.
To avoid reintroducing the issue, I have added some more tests for --live and --shared when used on a regular Docker container.
Member
|
Ok now I see. Had to look at original source to see what you were doing, github format made this confusing. LGTM Please update the patch |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Raise an exception that --live and --shared are not supported only after we are sure that the specified container/image is managed through OSTree. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
system-containers-more-tests
branch
from
b94656e to
6e95350
Compare
Collaborator
Author
|
updated here ⬆️ |
Member
|
📌 Commit 6e95350 has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 3, 2016
Raise an exception that --live and --shared are not supported only after we are sure that the specified container/image is managed through OSTree. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #405 Approved by: rhatdan
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 3, 2016
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #405 Approved by: rhatdan
rh-atomic-bot
pushed a commit
that referenced
this pull request
Jun 3, 2016
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #405 Approved by: rhatdan
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a few more tests