This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Atomic/scan.py: Don't keep open STDIN for scan#452
Merged
rhatdan merged 1 commit intoprojectatomic:masterfrom Jul 8, 2016
ybznek:master-non-tty
Merged
Atomic/scan.py: Don't keep open STDIN for scan#452rhatdan merged 1 commit intoprojectatomic:masterfrom ybznek:master-non-tty
rhatdan merged 1 commit intoprojectatomic:masterfrom
ybznek:master-non-tty
Conversation
Fix 'cannot enable tty mode on non tty input'
|
Can one of the admins verify this patch?
|
Member
|
@baude What do you think? This looks good to me. |
Member
|
LGTM, I didnt test but assume contributor did. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atomic scan fedora:24runsdocker -it ...and it needs to have interactive terminal.Consequences:
atomic scan fedora:24is not usable in cases likenohup atomic scan fedora:24ssh root@localhost atomic scan fedora:24It only prints
cannot enable tty mode on non tty input.