[merged] System containers: basic support for verify#506
[merged] System containers: basic support for verify#506giuseppe wants to merge 5 commits intoprojectatomic:masterfrom
Conversation
Atomic/syscontainers.py
Outdated
| tag = ":".join(imagebranch.replace("ociimage/", "").rsplit('-', 1)) | ||
| timestamp = OSTree.commit_get_timestamp(commit) | ||
|
|
||
| return {'Id' : commit_rev, 'RepoTags' : [tag], 'Names' : [], 'Created': timestamp, |
There was a problem hiding this comment.
Shouldn't this ID actually be the original docker image digest? And we insert a new OstreeChecksum field or something?
There was a problem hiding this comment.
the problem is that the commit having the manifest metadata cannot be mapped to a Docker layer, so I preferred to use the OSTree commit for both layers and the ID, so for now I am using the same ID used for images list.
With @yuqi-zhang we are currently discussing about the ID to use in the images list output as well (which currently is the commit_rev too), as we are thinking about changing there as well, so that it uses the Docker layer ID, but we didn't yet figure out what ID should be used for the metadata commit, which gives the name to the image.
|
No tests had to change for this? Is there no coverage? |
|
there is only a basic test for |
giuseppe
force-pushed
the
system-containers-basic-verify
branch
from
0d9f277 to
d674162
Compare
|
I added a fixup patch that adds a test for I made the change for the image ID we use in a separate patch, so now we use:
This should enable us now to fully support |
giuseppe
force-pushed
the
system-containers-basic-verify
branch
from
d674162 to
32b59ed
Compare
|
LGTM |
|
@cgwalters PTAL |
giuseppe
force-pushed
the
system-containers-basic-verify
branch
2 times, most recently
from
f13bc75 to
ca8918f
Compare
|
rebased ⬆️ |
It returns the information in a similar way to the Docker inspect format. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
To find the ID for an image, try in order: 1) Digest from the docker.manifest metadata 2) $SHA if $SHA in ociimage/$SHA is a valid checksum 3) OSTree commit Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
system-containers-basic-verify
branch
from
ca8918f to
151e787
Compare
|
📌 Commit 151e787 has been approved by |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #506 Approved by: rhatdan
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #506 Approved by: rhatdan
To find the ID for an image, try in order: 1) Digest from the docker.manifest metadata 2) $SHA if $SHA in ociimage/$SHA is a valid checksum 3) OSTree commit Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Closes: #506 Approved by: rhatdan
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
4 participants
No description provided.