This repository was archived by the owner on Oct 10, 2020. It is now read-only.
[merged] Fix wrong filtered variable in test_ps#533
Closed
yuqi-zhang wants to merge 1 commit intoprojectatomic:masterfrom
Closed
[merged] Fix wrong filtered variable in test_ps#533yuqi-zhang wants to merge 1 commit intoprojectatomic:masterfrom
yuqi-zhang wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
Collaborator
|
📌 Commit c8cd03c has been approved by |
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"type" is not a filterable variable. "runtime" is what the test is meaning to filter for. Perhaps in the future, "type" should be supported as an alternative for "runtime", but for now this is a quick fix.
On another note, if the user doesn't actually have docker/atomic containers set up, this test will always pass (since both atomic ps and docker ps gives the same output).