Skip to content
This repository was archived by the owner on Oct 10, 2020. It is now read-only.

[merged] Remove --force option and use --assumeyes#602

Closed
rhatdan wants to merge 1 commit intoprojectatomic:masterfrom
rhatdan:assumeyes
Closed

[merged] Remove --force option and use --assumeyes#602
rhatdan wants to merge 1 commit intoprojectatomic:masterfrom
rhatdan:assumeyes

Conversation

@rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 9, 2016

atomic images delete --force

Should force the remove of images that are in use, not answer the prompt yes.

atomic -y|--assumeyes images delete foobar

Should force the answer to yes

Also lots of cleanups of the man page.

@rhatdan
Copy link
Member Author

rhatdan commented Sep 9, 2016

@shishir-a412ed @jwhonce PTAL

@jwhonce
Copy link
Contributor

jwhonce commented Sep 9, 2016

LGTM 👍

@shishir-a412ed
Copy link

@rhatdan It is still asking me with a prompt Do you wish to delete ['fedora']? (y/N)

My setup:
Images: fedora
Container: 1 container based on fedora image.

When I do atomic images delete -f fedora I am expecting it to just delete the image fedora (something similar to docker rmi -f fedora). However I am getting the above prompt.
Is this expected behavior ?

Shishir

@rhatdan
Copy link
Member Author

rhatdan commented Sep 9, 2016

@shishir-a412ed

atomic images delete -f fedora

Does a force image removal, same as docker rmi -f fedora
Thats what this change is about.

Assume yes is a atomic option.

atomic -y images delete fedora

Is the syntax I am proposing here. This is based on the way dnf/yum work
dnf -y update ...

@shishir-a412ed
Copy link

@rhatdan Thanks for the explanation.
LGTM.

Previous patch broke test cases
@rhatdan
Copy link
Member Author

rhatdan commented Sep 12, 2016

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit 2270e87 has been approved by rhatdan

@rh-atomic-bot
Copy link

⌛ Testing commit 2270e87 with merge f3c0368...

@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: rhatdan
Pushing f3c0368 to master...

@rh-atomic-bot rh-atomic-bot changed the title Remove --force option and use --assumeyes [merged] Remove --force option and use --assumeyes Sep 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants