[merged] Introduce registry inspect methods#687
[merged] Introduce registry inspect methods#687baude wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
| raise ValueError('Error parsing input: "{}" invalid'.format(input_image)) | ||
| if all([True if x else False for x in [registry, repo, image, tag]]): | ||
| return input_image | ||
| if all([True if x else False for x in [registry, image, tag]]): |
There was a problem hiding this comment.
Why do the first one? Doing just this block should be enough?
|
@runcom PTAL. Since he is doing some of the stuff skopeo does for remote viewing... |
|
Are you handling the case where there are multiple registires? atomic pull rhel7tools Does this work there? |
|
|
||
|
|
||
| class TestAtomicUtil(unittest.TestCase): | ||
| IMAGE = 'docker.io/library/busybox:latest' |
There was a problem hiding this comment.
is util.decompose working with a digest also? e.g. docker.io/library/busybox@sha256:%HEX%
|
patch LGTM
The loop over the available registries in docker should be here https://github.com/projectatomic/atomic/pull/687/files#diff-1e7bfb73126e6f7e89b71bbe478132d3R249 right Brent? |
|
Right as long as rhel7tools ends up being something like I am fine with this patch. |
Add two classes and several new methods for inspecting registries and images. These methods are helpful for: * taking user input (i.e. image names, partial image names) and determining the fully qualified names. * determining the fq name when the registry is omitted by the user. * obtaining image manifests * mimicing skopeo inspect
|
Current output for this looks like: |
|
At the risk of merging my own code ... but doing so to unblock CAHC |
|
📌 Commit 4fc217e has been approved by |
| from urllib2 import parse_http_list, parse_keqv_list #pylint: disable=import-error | ||
|
|
||
|
|
||
| def jose_base64_urldecode(in_str): |
There was a problem hiding this comment.
Who's "jose"? 😄 Did this code come from somewhere else?
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
5 participants
Add two classes and several new methods for inspecting
registries and images. These methods are helpful
for:
the fully qualified names.