This repository was archived by the owner on Oct 10, 2020. It is now read-only.
[merged] atomic_dbus: keep the name until the process exits#770
Closed
larskarlitski wants to merge 1 commit intoprojectatomic:masterfrom
larskarlitski:keep-name
Closed
[merged] atomic_dbus: keep the name until the process exits#770larskarlitski wants to merge 1 commit intoprojectatomic:masterfrom larskarlitski:keep-name
larskarlitski wants to merge 1 commit intoprojectatomic:masterfrom
larskarlitski:keep-name
Conversation
The call dbus.service.BusName() claims the name while the returned object is alive. It wasn't stored into a variable, so the name was released immediately, but the service keeps running (potentially indefinitely) with no use. Fix this by calling request_name() directly, so that we can give useful feedback (and end the process) when the name is already owned by another process. Fixes #763
|
Can one of the admins verify this patch?
|
Member
|
bot, add author to whitelist |
Member
|
@cgwalters PTAL |
Member
|
I'd be surprised if there wasn't a nicer binding for this somewhere in slip or python-dbus, but eh: |
Member
|
Looks like the fedora/24/atomic failure is the test suite not being safe for concurrent runs on the same system. |
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call dbus.service.BusName() claims the name while the returned
object is alive. It wasn't stored into a variable, so the name was
released immediately, but the service keeps running (potentially
indefinitely) with no use.
Fix this by calling request_name() directly, so that we can give useful
feedback (and end the process) when the name is already owned by another
process.
Fixes #763