This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Closed
Conversation
rhatdan
reviewed
Feb 6, 2017
Atomic/diff.py
Outdated
| try: | ||
| image_list.append(DiffObj(image, args)) | ||
| except mount.SelectionMatchError as e: | ||
| print(e) |
atomic_dbus.py
Outdated
| args = self.Args() | ||
| args.container = containers[0] | ||
| args.containers = containers[1:] | ||
| print(type(containers)) |
atomic_dbus_client.py
Outdated
| if not isinstance(command, (list, tuple)): | ||
| command = [ command ] | ||
| return self.dbus_object.Run(image, name, spc, detach, command, dbus_interface="org.atomic", timeout = 2147400) | ||
| return self.dbus_object.Run(image, name, spc, detach, command, dbus_interface="org.atomic", timeout = 2147400) |
Member
|
@baude Tests are failing with an undefined e? |
|
☔ The latest upstream changes (presumably 2ebeb1d) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Needs a rebase. |
Member
|
bot, retest this please |
Member
Author
|
@rh-atomic-bot +877ff09d |
Member
|
@rh-atomic-bot r=rhatdan 877ff09d |
|
🙀 |
Member
|
@rh-atomic-bot r=rhatdan 87ff09d |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Feb 12, 2017
Closes: #873 Approved by: rhatdan
|
☀️ Test successful - status-redhatci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensuring that dbuss run, diff, and containerdelete all work.