Conversation
atomic_dbus_client.py
Outdated
|
|
||
| @polkit.enable_proxy | ||
| def Install(self, image, name=None, user=False, system=False, remote="", setvalues=None, extra_args=None): | ||
| def Install(self, image, name=None, system=False, remote=False, storage=None, user=False, setvalues= None, extra_args=None): |
There was a problem hiding this comment.
Looks like you have a bogus space after setvalues.
atomic_dbus.py
Outdated
| def Install(self, image, name=None, system=False, remote=False, storage=None, user=False, setvalues=None, extra_args=None): | ||
| if setvalues is None: | ||
| setvalues = [] | ||
| if extra_args is None: |
There was a problem hiding this comment.
Should we do the extra check for whether setvalues and exta_args if passed in is a list? Actually I think dbus would fail if they were not a list.
extra_args is weird, since it needs to precisely be setup by the user to match the internals of the Atomic python library.
I take it, this is just for debuging?
There was a problem hiding this comment.
Not for debug. My understanding is that extra_args needs to be a list. So if nothing is passed (i.e. None), we just pass an empty list.
There was a problem hiding this comment.
I added assertions that set_values and extra_args must be a list.
There was a problem hiding this comment.
Do you ever see someone passing extra_args across dbus? I think we should just remove it from the dbus inteface and hard code it to [ ]
There was a problem hiding this comment.
I have no idea. I was just following suit. I'll remove it and hard set it like you said.
There was a problem hiding this comment.
I meant hard code it on the server side and don't allow it to be passed from the client side.
baude
force-pushed
the
dbus_install
branch
4 times, most recently
from
dc4f631 to
0425569
Compare
|
@rhatdan should be ready |
Enable for performing atomic install over dbus.
|
☀️ Test successful - status-redhatci |
3 participants
Enable for performing atomic install over dbus.