Skip to content
This repository was archived by the owner on Oct 10, 2020. It is now read-only.

smarter_copy(): Split into separate copy() and remove() functions#892

Closed
shishir-a412ed wants to merge 1 commit intoprojectatomic:masterfrom
shishir-a412ed:smarter_copy
Closed

smarter_copy(): Split into separate copy() and remove() functions#892
shishir-a412ed wants to merge 1 commit intoprojectatomic:masterfrom
shishir-a412ed:smarter_copy

Conversation

@shishir-a412ed
Copy link

Signed-off-by: Shishir Mahajan shishir.mahajan@redhat.com

@shishir-a412ed
Copy link
Author

In test_storage.sh when teardown() executes, it calls smarter_copy() to copy the backup file (/etc/sysconfig/docker-storage-setup.atomic-tests-backup) back to original (/etc/sysconfig/docker-storage-setup). However it does not clean it up and leaves the backup file behind.

This PR splits the smarter_copy() into separate copy() and remove() functions which fixes the above issue and easier to read.

ping @rhatdan @baude

Shishir

Signed-off-by: Shishir Mahajan <shishir.mahajan@redhat.com>
@shishir-a412ed
Copy link
Author

@rhatdan @baude Any updates on this one ?

@rhatdan
Copy link
Member

rhatdan commented Feb 20, 2017

LGTM

@rhatdan
Copy link
Member

rhatdan commented Feb 20, 2017

@rh-atomic-bot r+ 740d35f

@rh-atomic-bot
Copy link

⌛ Testing commit 740d35f with merge db08293...

@rh-atomic-bot
Copy link

☀️ Test successful - status-redhatci
Approved by: rhatdan
Pushing db08293 to master...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants