This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Enable atomic push in dbus and add integrations tests#907
Closed
baude wants to merge 1 commit intoprojectatomic:masterfrom
Closed
Enable atomic push in dbus and add integrations tests#907baude wants to merge 1 commit intoprojectatomic:masterfrom
baude wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
Member
Author
For potential cockpit use, we have enabled atomic push. It returns a 0 if successful or throws a dbus Exception upon failure. Added a series of integrations tests as well.
Member
|
Should we add a dbus interface to return registry choices for cockpit to display? |
Member
Author
|
@rhatdan We sure can, but ideally we should be able to detect this on the fly if we can ever get the registry API to just change a bit. Let me know what you want and I'll do it. |
Member
|
📌 Commit b956711 has been approved by |
Member
|
☀️ Test successful - status-redhatci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For potential cockpit use, we have enabled atomic push. It returns
a 0 if successful or throws a dbus Exception upon failure. Added
a series of integrations tests as well.