This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Update man pages for atomic storage commands.#918
Closed
shishir-a412ed wants to merge 1 commit intoprojectatomic:masterfrom
Closed
Update man pages for atomic storage commands.#918shishir-a412ed wants to merge 1 commit intoprojectatomic:masterfrom
shishir-a412ed wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
Author
rhatdan
reviewed
Feb 27, 2017
docs/atomic-storage.1.md
Outdated
| on "/var/lib/containers". | ||
| Add the mountpath where logical volume for container storage would be mounted to | ||
| /etc/sysconfig/docker-storage-setup. E.g. --rootfs="/var/lib/containers". This | ||
| will mount "container-root-lv" on "/var/lib/containers". |
Member
There was a problem hiding this comment.
s/container-root-lv/CONTAINER_ROOT_LV_NAME/g
docs/atomic-storage.1.md
Outdated
| Add the name of the volume group for the storage pool to | ||
| /etc/sysconfig/docker-storage-setup. | ||
| E.g atomic storage modify --vgroup=atomicos would add | ||
| VG=atomicos to /etc/sysconfig/docker-storage-setup. |
Member
There was a problem hiding this comment.
All of the examples should be like this.
docs/atomic-storage.1.md
Outdated
| contains "%" in syntax are acceptable. If value does not contain | ||
| "%" it is assumed value is suitable for "lvcreate -L". | ||
| Note: You must set --lvname and --rootfs when setting --lvsize. | ||
| This would set docker-storage-setup option: CONTAINER_ROOT_LV_SIZE. |
Member
There was a problem hiding this comment.
+E.g atomic storage modify --llvsize=20%FREE would add
+CONTAINER_ROOT_LV_SIZE=20%FREE to /etc/sysconfig/docker-storage-setup.
shishir-a412ed
force-pushed
the
man_atomic_storage
branch
from
43f7198 to
0fc7c58
Compare
Author
|
@rhatdan PTAL. |
rhatdan
reviewed
Mar 1, 2017
docs/atomic-storage.1.md
Outdated
| **--add-device** | ||
| Add block devices to storage pool. This command will expand your devicemapper | ||
| Add the block devices names to /etc/sysconfig/docker-storage-setup. | ||
| You can then run /usr/bin/docker-storage-setup to add the block devices |
docs/atomic-storage.1.md
Outdated
| /etc/sysconfig/docker-storage-setup. | ||
| E.g. atomic storage modify --rootfs="/var/lib/containers" | ||
| --lvname="container-root-lv" will add | ||
| `CONTAINER_ROOT_LV_MOUNT_PATH="/var/lib/containers"` to |
Member
There was a problem hiding this comment.
You need to add comtnet about adding container-root-lv also.
docs/atomic-storage.1.md
Outdated
| "lvcreate -l", then only those values which contains "%" in syntax are acceptable. | ||
| If value does not contain "%" it is assumed value is suitable for "lvcreate -L". | ||
| E.g. atomic storage modify --rootfs="/var/lib/containers" --lvname="container-root-lv" | ||
| --lvsize=20%FREE will add `CONTAINER_ROOT_LV_SIZE=20%FREE` to |
Member
There was a problem hiding this comment.
Add comment about what container-root-lv will be in the config file.
docs/atomic-storage.1.md
Outdated
|
|
||
| **--graph** | ||
| Root of the docker runtime. atomic will search for either /var/lib/docker or /var/lib/docker-latest, if only one exists, atomic will select it as the default. If both exists or you are running docker with a graph storage at a non default location, you need to pass this flag. | ||
| Root of the docker runtime. atomic will search for either /var/lib/docker or |
Member
There was a problem hiding this comment.
Can you change docker runtime to container runtime.
shishir-a412ed
force-pushed
the
man_atomic_storage
branch
from
0fc7c58 to
b417d3c
Compare
Signed-off-by: Shishir Mahajan <shishir.mahajan@redhat.com>
shishir-a412ed
force-pushed
the
man_atomic_storage
branch
from
b417d3c to
d06e64b
Compare
Author
|
@rhatdan PTAL. |
Member
|
☀️ Test successful - status-redhatci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shishir Mahajan shishir.mahajan@redhat.com