This repository was archived by the owner on Oct 10, 2020. It is now read-only.
syscontainers: when using --rootfs create a symlink to rootfs#922
Closed
giuseppe wants to merge 2 commits intoprojectatomic:masterfrom
Closed
syscontainers: when using --rootfs create a symlink to rootfs#922giuseppe wants to merge 2 commits intoprojectatomic:masterfrom
giuseppe wants to merge 2 commits intoprojectatomic:masterfrom
Conversation
In this way it is still possible to access $DESTDIR/rootfs as in the case --rootfs is not specified. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Collaborator
Author
|
@yuqi-zhang a simple change for the --rootfs case. What do you think? @rh-atomic-bot delegate=yuqi-zhang |
|
✌️ @yuqi-zhang can now approve this pull request |
1 similar comment
|
✌️ @yuqi-zhang can now approve this pull request |
Member
|
LGTM |
giuseppe
force-pushed
the
syscontainers-rootfs-symlink
branch
from
15c2b04 to
6504a9b
Compare
giuseppe
force-pushed
the
syscontainers-rootfs-symlink
branch
from
6504a9b to
23e417d
Compare
Contributor
|
LGTM, will merge when tests pass |
Member
|
Note you actually don't need to wait for the per-PR tests - our instance of Homu reruns them for the merge. This is a nice advantage of Homu - you can fearlessly drop an |
Contributor
|
Cool, |
|
☀️ Test successful - status-redhatci |
mike-nguyen
added a commit
to mike-nguyen/atomic-host-tests
that referenced
this pull request
Apr 27, 2017
Update the test to reflect the symlink of the rootfs dir when using --rootfs. See projectatomic/atomic#922
miabbott
pushed a commit
to projectatomic/atomic-host-tests
that referenced
this pull request
Apr 27, 2017
Update the test to reflect the symlink of the rootfs dir when using --rootfs. See projectatomic/atomic#922
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this way it is still possible to access $DESTDIR/rootfs as in the
case --rootfs is not specified.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com