This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Closed
Conversation
An exception was being thrown when trying to run a command inside an already running container. For example: sudo atomic run foobar echo true The problem was a lack of a setter for user_command in the container object as well as some mishandled string <-> list conversions.
Prior to refactoring, we had a check_latest method that would check to see if the image being used by container was the latest image by simply comparing hash IDs. Adding this back in and refactoring into docker.py.
rhatdan
reviewed
Mar 14, 2017
Atomic/objects/container.py
Outdated
|
|
||
| @user_command.setter | ||
| def user_command(self, value): | ||
| self._user_command = value No newline at end of file |
Member
|
Just a nit and LGTM |
If the image is built (and updated) locally, we need to handle this differently than if the image came from a registry. We now can try/except our way through things and properly handle.
Member
Author
|
updated per comments. |
Member
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 16, 2017
Prior to refactoring, we had a check_latest method that would check to see if the image being used by container was the latest image by simply comparing hash IDs. Adding this back in and refactoring into docker.py. Closes: #938 Approved by: rhatdan
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 16, 2017
If the image is built (and updated) locally, we need to handle this differently than if the image came from a registry. We now can try/except our way through things and properly handle. Closes: #938 Approved by: rhatdan
|
☀️ Test successful - status-redhatci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.