This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Allow arbitrary files in test images.#97
Merged
rhatdan merged 1 commit intoprojectatomic:masterfrom Jul 21, 2015
Merged
Conversation
Signed-off-by: William Temple <wtemple@redhat.com>
Member
|
LGTM |
rhatdan
added a commit
that referenced
this pull request
Jul 21, 2015
Allow arbitrary files in test images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch will allow arbitrary files to be inserted into the test images.
If you have a file hierarchy that looks like this:
Then the directory
Dockerfile.<id>.dwill be available to the image at build time, and can be added to the image, e.g. (with an of 'foo') asDockerfile.foo:The script will also now rebuild any test-images whose files have changed.
@rhatdan RFC. I think this is the cleanest way to add arbitrary files to these test images.
@sallyom This should enable you to add scripts/etc. to the test images, and you should then be able to take the "docker build" logic out of your test script.
Signed-off-by: William Temple wtemple@redhat.com