Atomic/install.py: Fix what c134ee5 broke#973
Atomic/install.py: Fix what c134ee5 broke#973baude wants to merge 1 commit intoprojectatomic:masterfrom
Conversation
|
Sorry for not catching this case. There is one minor problem with this fix being that remote ostree images still get ignored, i.e. if you do something like "atomic install --system gscrivano/flannel" (which has atomic.type=ostree) it would just say I will take another look at this today. Thanks for the fix! |
|
Confirming what @yuqi-zhang said, this appears to fix the case of |
baude
force-pushed
the
fix_install
branch
2 times, most recently
from
d72726e to
eb5573c
Compare
The commit c134ee5 broke the ability for atomic install to pull an image if it isnt present. Also, changed the flow in install.py to use more of the backend objects when determining the backend, the image object, and the remote image objects.
|
The latest commit works better for the various use cases. 👍 |
|
LGTM |
|
@rhatdan shall i merge? |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-redhatci |
5 participants
The commit c134ee5 broke the ability for atomic install to pull an image
if it isnt present.