Syntax 0.8, part 5: Update reference fixtures #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
force-pushed
the
zeroeight-part5
branch
from
b13337d to
8860713
Compare
stasm
force-pushed
the
zeroeight-part5
branch
2 times, most recently
from
e28ade7 to
b555fe7
Compare
Contributor
Author
|
This PR depends on #311 which hasn't been merged yet. @Pike, if you want to review this first, the compare view might be helpful. Thanks. |
Contributor
Author
|
I should also note that this PR is only about tests. Most of it is just test fixtures copied from the reference parser. The only code change is in the test suite which compares these fixtures: stasm/fluent.js@zeroeight-part4-macros...zeroeight-part5#diff-fa220b798ccf9ee1a255963fcf2239b2R49 |
Pike
approved these changes
Nov 29, 2018
Contributor
Pike
left a comment
Pike
left a comment
There was a problem hiding this comment.
:-), yay for more depth in tests.
Port fixture changes from:
projectfluent/fluent@bf8fff4
Port reference fixtures from:
projectfluent/fluent@741be04
stasm
force-pushed
the
zeroeight-part5
branch
from
b555fe7 to
2044437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 5 of #303:
Stop parsing Junk on lines which look like Entries fluent#211, tests only
Allow all Unicode characters fluent#207, tests only
With this PR the reference tests in
fluent-syntaxnow compare the content of allJunkentries! (Comparing annotations and spans is far away.)Depends on #311.